Fix: [OpenGL] Don't use OpenGL on MESA software renderers. #8758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
previously approved these changes
Feb 27, 2021
Performance in this case is worse than not using OpenGL, so just let OTTD fall back to a different video driver.
michicc
force-pushed
the
pr/gl_llvmpipe
branch
from
ac03246
to
50d1957
Compare
TrueBrain
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
MESA software OpenGL is slower than not using it.
Description
Just block it and let OpenTTD fallback to another video dirver.
Limitations
If the reported renderer string changes, the test might fail in the future.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.