My problem with these kind of changes: it heavily depends on taste.

Is it a graph? Yes. So under the graphs icon.
Has it a relation with industries? Yes, so under the industry icon.

You do not really give a motivation why you see it one way or the other, just mention some facts :)

What worries me more about these kind of changes: it can be frustrating for our existing player base. So I try to balance if it adds sufficient clarity to new players to make it worth "retraining" our current players.

And I am really unsure about this one. Is the benefit to new players higher than the frustration/confusion this will undoubtedly give to existing players? Or will existing players welcome this, as they always first look in the wrong menu? I don't know. And your motivation is not helping me left or right :D

So, could you explain your motivation behind this change a bit more? Is it just your local OCD that triggered? Or is there some deeper motivation going on?

You are absolutely correct with your concerns about retraining existing players. I can't make that judgement whether it's worth it, but I can expand on my logic.

My motivation was to organize the GUI in a logical manner so that players who don't already know where to look (new and inexperienced players, but I am trying to improve things for all players) can find things where they expect them to be.

The cargo payment chart has only one thing in common with the other graphs in its current menu: it is a point and line graph. Everything else is different:

• The player might look at the graph to determine what to do in the future; others are used to look at past performance
• The points and lines represent cargos; others are companies
• The data is global and unchanging; others show data over time relating to each company
• The period is days in transit; others are quarters and years

In my mind, this graph is a sister to the industry chains chart and belongs with it. The only reason it's with graphs is because is is visually — but not functionally — similar.

Does that help?

But the cargo payments graph doesn't just pertain to industry, since it also tells the rates for passenger and mail transport.
I vote don't move, keep it where it has always been.

Thank you @2TallTyler for the motivation; that really helps :)

What for me is going to lead to closing this PR in a moment, is that I do not think that moving a single entry to another menu is going to help out; I think the argument for both locations is solid, and that means it is more a personal taste.

But maybe more importantly, it shows that it could be in two places and "belong" depending on how you look at it. I looked a bit more in the menu, and I find more odd things that could be in different places. For example, the "cargo flow legend", I always look under the industry icon first. I did not expect that under the map icon.
Also looking under the settings icon, there are a lot of settings there that seems to be out of place. We are basically lacking a "Video Settings" GUI, as we have more of these things all over the place.

In general, I think if (and that is an "if"!) we want to move things around, we should first make a bigger picture where we want this to go, and do it from there. So we do not move individual items, but move them all at once. And if (and again: "if") we want to do this, we maybe should be a bit bold, and just forget everything that there is now, and revamp it completely.

But, knowing our community, change is difficult, so I am not sure those "if"s should come to be.

Either way, to reiterate, moving this single entry doesn't seem like a good move to me for OpenTTD just now. But, as always, I really appreciate you making these PRs :)

Makes sense to me. Thanks for explaining!