Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Don't show global goals in company goal windows #8709

Merged
merged 2 commits into from Mar 8, 2021

Conversation

ldpl
Copy link
Contributor

@ldpl ldpl commented Feb 20, 2021

Motivation / Problem

Despite having a dedicated window global goals are also shown in every company goal window distracting players from the important part or hiding it below the scrollbar (in 1.11). I see no reason for that as even in the rare case when the player needs both he can just open two windows. It also simplifies the code a lot and removes the need for awkward global/company goal subheaders.

Description

Before:
Screenshot from 2021-02-21 01-11-52

After (updated):
Screenshot from 2021-02-21 02-34-21

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@nielsmh
Copy link
Contributor

nielsmh commented Feb 20, 2021

Could I suggest showing a line or something in the company goals window to still remind the player if there are also global goals, and they need to check both lists to know everything?

@TrueBrain
Copy link
Member

Random thought: button in the title bar that reads "Global" if you are looking at your company window, and "Company" if you are looking at the global, just to hint players there is more to be found?

@2TallTyler
Copy link
Member

Random thought: button in the title bar that reads "Global" if you are looking at your company window, and "Company" if you are looking at the global, just to hint players there is more to be found?

+1.

A good example of this might be the button on the company performance graph, which opens the detailed rating window.

@frosch123
Copy link
Member

I think the "global goals" window is for spectators only. It's pretty hidden for companies.
I guess it would be okay to hide the headline "Global goals", when there are none. But I prefer having all goals in one window.

@LordAro LordAro merged commit 56911a8 into OpenTTD:master Mar 8, 2021
@ldpl ldpl deleted the no-global-goals branch September 19, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants