Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a semi-complex margin-bottom-end test #27718

Merged
merged 4 commits into from Apr 28, 2022

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Feb 21, 2021

On my website:

http://www.gtalbot.org/BrowserBugsSection/CSS3LogicalProps/margin-block-end-scroll-area-001.html

||
v

[update]
Slightly modified and now at:
http://www.gtalbot.org/BrowserBugsSection/CSS3Overflow/margin-block-end-scroll-area-001.html
[/update]

This test is a slightly modified version of the original testcase from Morten Stenshorne (credits given).

This test spun from Issue 750992.

The issue with Chrome 88 is also noticeable with 'overflow: auto'.

@TalbotG TalbotG self-assigned this Feb 21, 2021
@TalbotG
Copy link
Contributor Author

TalbotG commented Mar 14, 2021

A green-versus-red variation of the -001 test above:

http://www.gtalbot.org/BrowserBugsSection/CSS3LogicalProps/margin-block-end-scroll-area-002.html

||
v

[update]
Slightly modified and now at:
http://www.gtalbot.org/BrowserBugsSection/CSS3Overflow/margin-block-end-scroll-area-002.html
[/update]


The failure demonstrated by both tests can be seen and still exists with 'overflow: auto' (instead of 'overflow: hidden').

Copy link
Contributor

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be tagged against https://www.w3.org/TR/css-overflow-3/#scrollable and filed under css-overflow instead of css-logical, but otherwise it seems correct.

I'd also add a comment next to the font-size declaration, to explain that this is to influence the margin on the P without setting it directly.

@TalbotG
Copy link
Contributor Author

TalbotG commented Mar 16, 2022

moved : margin-block-end-scroll-area-001.html -> ../css-overflow/margin-block-end-scroll-area-001.html

moved : reference/ref-if-there-is-no-red.xht -> ../css-overflow/reference/ref-if-there-is-no-red.xht

@TalbotG TalbotG requested a review from fantasai March 16, 2022 23:56
@fantasai fantasai merged commit 08cf400 into web-platform-tests:master Apr 28, 2022
@TalbotG TalbotG deleted the CSS3LogicalProps-GT-PR1 branch April 28, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants