[OSX] Draw immediately instead of waiting for the event loop. #8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When drawing an 8bpp screen buffer, palette resolving was done for each dirty rectangle. In areas with high activity, this would mean a pixel might have been resolved multiple times. Also, if too many individual updates were queued, the whole screen would be refreshed, even if unnecessary. All other drivers only keep one overall dirty rect, so do it here as well.
michicc
changed the title
|
New title |
TrueBrain
reviewed
Feb 20, 2021
|
Tested for a few minutes, no visible change for me (no gain, but also nothing regressed as far as I can tell) :) |
michicc
force-pushed
the
pr/osx_display
branch
from
3f95716
to
7e22fb7
Compare
TrueBrain
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Using the event loop for displaying introduces an indeterminate delay. As we have now have a draw-tick, we can draw immediately.
Description
#8702 for OSX basically.
Limitations
The whole window compositor is still somewhat coupled to screen refresh, so it might not actually cause any visible change.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.