Fix #8276: Crash when a NewGRF object's size was not set #8719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
#8276
NewGRF's object size defaulted to 0x0, which if the object's size property (0xBC) was not set, and the game falls on its face trying to render a 0x0 object.
Description
Add a default of 1x1, and add validation that the GRF setting a size does not set a 0 width or height
Limitations
Technically speaking, the actual bug is that the size (0xBC) wasn't set in the GRF at all. We still can't detect that, and I don't see a way to do so with the current code layout.
Probably an NML bug that it allows this at all.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.