Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Dependabot for depenency updates #27717

Merged
merged 1 commit into from Mar 10, 2021

Conversation

nschonni
Copy link
Contributor

Skip double building for branches since the updates get submitted as PRs

@nschonni
Copy link
Contributor Author

Maybe the python part should be skipped, as I see there is something else with https://github.com/web-platform-tests/wpt/blob/master/.pyup.yml that may already do that part

@jgraham
Copy link
Contributor

jgraham commented Feb 22, 2021

I believe there was a reason we chose not to use dependabot, but I've forgotten what it was. @gsnedders ?

@nschonni
Copy link
Contributor Author

It may be worth keeping the github-actions one, even if the NPM and Python parts aren't wanted

@gsnedders
Copy link
Member

I believe there was a reason we chose not to use dependabot, but I've forgotten what it was. @gsnedders ?

Being able to restrict the versions it updates to; like how we have pillow==6.2.2; python_version <= '2.7' # pyup: <7.0 (which is presumably now redundant).

@nschonni
Copy link
Contributor Author

Yeah, it looks like their filtering is different, and might not support that syntax https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates#specifying-dependencies-and-versions-to-ignore

Should I drop the PIP part, but keep the NPM and Actions?

@foolip
Copy link
Member

foolip commented Feb 25, 2021

Skipping PIP for now sounds good. Even if we want to do it, it's good to do it separately so it's easier to revert just that if it turns out to not work well.

@nschonni
Copy link
Contributor Author

OK, rebased out the PIP part, and left in the GitHub Actions + NPM updating

.github/dependabot.yml Outdated Show resolved Hide resolved
@jgraham
Copy link
Contributor

jgraham commented Mar 9, 2021

So if the concern with dependabot was Python-version-specific pinning, I think we could switch to that now that we're on Py3?

@foolip
Copy link
Member

foolip commented Mar 9, 2021

It that was the only issue, then having a single dependency bumper would be great!

@nschonni
Copy link
Contributor Author

nschonni commented Mar 9, 2021

let me know if you want to add back Python and/or drop pyup here, or if it's better for you folks to do that in a separate PR

@foolip
Copy link
Member

foolip commented Mar 9, 2021

I'll defer to @jgraham on that.

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this as is, and leave the Python questions for a separate PR.

@gsnedders gsnedders merged commit 64004e8 into web-platform-tests:master Mar 10, 2021
@foolip
Copy link
Member

foolip commented Mar 10, 2021

So it looks like Dependabot will also send updates to forks: https://github.com/autofoolip/wpt/pulls.

Judging by dependabot/dependabot-core#2804 it might not affect all forks. Has anyone else gotten a bunch of PRs?

@nschonni nschonni deleted the add-dependabot branch March 10, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants