Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ninja: Ninja issue 1510 patch source update to ninja upstream #82946

Closed
wants to merge 1 commit into from
Closed

ninja: Ninja issue 1510 patch source update to ninja upstream #82946

wants to merge 1 commit into from

Conversation

twhitehead
Copy link
Contributor

@twhitehead twhitehead commented Mar 19, 2020 •
edited

Motivation for this change

The repository the ninja patch was being pulled from no longer exists. This changes it to the primary ninja repository which should hopefully exist for a long time yet.

I have tested it in the sense that I verified that I

  • can't fetch the patch from the old URL
  • can fetch the patch from the new URL

It doesn't technically change the derivation though, so the system does not rebuild anything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@twhitehead
Copy link
Contributor Author

Note that master has updated the version of ninja so this is not applicable there. I would like to backport this to 19.09 and 19.03 though. I can open separate pull requests that cherry pick this one once it is accepted if that works best.

@roberth roberth added the 8.has: port to stable A PR already has a backport to the stable release. label May 22, 2020
@twhitehead
Copy link
Contributor Author

Looks like this has since been addressed in 91d4e9a, so closing.

@twhitehead twhitehead closed this Jan 29, 2021
@twhitehead twhitehead deleted the ninja-patch-source branch January 29, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twhitehead @roberth @alyssais