Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/hydra: don't create home of hydra #111134

Closed
wants to merge 1 commit into from
Closed

nixos/hydra: don't create home of hydra #111134

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 29, 2021

hydra-init is doing 750 on /var/lib/hydra,
while create-users-groups does 700.
There are cases where hydra-init is not restarted after
create-users-groups runs, causing hydra services like the queue runner
to fail.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos/hydra: don't create home of hydra
f62d184 
hydra-init is doing 750 on /var/lib/hydra,
while create-users-groups does 700.
There are cases where hydra-init is not restarted after
create-users-groups runs, causing hydra services like the queue runner
to fail.
@Mic92
Copy link
Member Author

Mic92 commented Jan 29, 2021

cc @nlewo

@nlewo
Copy link
Member

nlewo commented Jan 29, 2021

@GrahamcOfBorg test hydra.hydra-unstable

@cole-h
Copy link
Member

cole-h commented Jan 29, 2021 •
edited

Dupe of #110722.

I don't care which is merged, but it would be nice to have the comment from that PR in this one if we decide to merge this one.

@Mic92
Copy link
Member Author

Mic92 commented Jan 29, 2021

Merged the other one.

@Mic92 Mic92 closed this Jan 29, 2021
@Mic92 Mic92 deleted the hydra branch January 29, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @nlewo @cole-h