libschrift: 0.9.1 -> 0.10.0 #111152
libschrift: 0.9.1 -> 0.10.0 #111152
Conversation
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and are new build failure:
|
|
@SuperSandro2000 can you test the latest commit on darwin for me? This should fix the build. |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
sternenseemann
force-pushed
the
libschrift-0.10.0
branch
from
fb271cf
to
6627276
Compare
On darwin unsigned long int != uint_fast32_t: https://opensource.apple.com/source/Libc/Libc-1439.40.11/include/_types/_uint32_t.h.auto.html Thus the build fails as SFT_Glyph is defined as unsigned long, but schrift.c uses uint_fast32_t everywhere instead of SFT_Glyph. We fix this by adjusting the int type in the header which should be fine for now. This patch is technically not required for Linux, but it doesn't hurt either as unsigned long == uint_fast32_t.
sternenseemann
force-pushed
the
libschrift-0.10.0
branch
from
6627276
to
9102e70
Compare
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
Motivation for this change
https://github.com/tomolt/libschrift/blob/master/CHANGELOG.md#v0100
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)