Add github notifications for evals (rebased) #852
+545
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I choose to have @pikajude as the co-author instead of committing as them, because I think the commit wouldn't be verified in that case? I'm not sure, let me know if I should change this |
pingiun
force-pushed
the
github-eval-notifies
branch
8 times, most recently
from
2886e57 to
1e2c9e3
Compare
|
Changing this to draft because I am still trying to get the new test case to succeed |
pingiun
force-pushed
the
github-eval-notifies
branch
from
1e2c9e3 to
c0fb1dc
Compare
pingiun
force-pushed
the
github-eval-notifies
branch
from
c0fb1dc to
4af9a22
Compare
|
The new check is now succeeding on my hydra instance: https://hydra.technicie.nl/build/499 |
pingiun
changed the title
|
I wonder if it would be possible to test this feature similarly to #878, without a separate, and relatively quite heavy VM test? |
Good idea, I'll try it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #712, because it seemed to me it got stale
I have used this functionality on my own server for a while and it seems to work fine. I adapted the PR created by @pikajude so it's based on the latest master, it uses python instead of perl tests, and it includes the suggestions from @knl
Also in response this point of @knl:
I believe this is possible because you have quite a lot of freedom in the context name via StringInterpolate
If this PR is merged, #712 can be closed