Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.MathPlanePath: 127 -> 129 #111222

Merged
merged 1 commit into from Jan 31, 2021
Merged

perlPackages.MathPlanePath: 127 -> 129 #111222

merged 1 commit into from Jan 31, 2021

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Jan 29, 2021 •
edited

Motivation for this change

This fixes the build failure introduced by c5b0de9,
which indirectly broke slic3r.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edef1c
perlPackages.MathPlanePath: 127 -> 129
81228c9 
This fixes the build failure introduced by c5b0de9,
which indirectly broke slic3r.
@edef1c edef1c requested a review from stigtsp as a code owner January 29, 2021 23:03
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111222 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  • perl530Packages.MathPlanePath: log was empty
1 package built:
  • perl532Packages.MathPlanePath
$ nix --experimental-features nix-command build --no-link --keep-going -f /Users/user/.cache/nixpkgs-review/pr-111222/build.nix  
error: --- Error -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
nixbuilder for '/nix/store/s0vfw2ni1n9zi289f7bkaprhsfx57cvl-perl5.30.3-Math-BigInt-Lite-0.19.drv' failed with exit code 2; last 10 log lines:
Test Summary Report   
-------------------    
t/bigintpm.t            (Wstat: 3072 Tests: 4026 Failed: 12)   
Failed tests:  2938, 2940, 2942, 2958, 2960, 2962, 3038      
3040, 3042, 3058, 3060, 3062                            
Non-zero exit status: 12                               
Files=17, Tests=19313, 20 wallclock secs ( 4.61 usr  1.40 sys + 18.29 cusr  1.73 csys = 26.03 CPU)      
Result: FAIL                                                                     
Failed 1/17 test programs. 12/19313 subtests failed.                       
make: *** [Makefile:866: test_dynamic] Error 255                           
error: --- Error -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
nix1 dependencies of derivation '/nix/store/1miydvw08n68wv90jnmjw2digrygfd0z-perl5.30.3-Math-PlanePath-129.drv' failed to build

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111222 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • perl530Packages.MathPlanePath: log was empty
2 packages built:
  • perl532Packages.MathPlanePath
  • slic3r

stigtsp
stigtsp approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

perl530Packages.MathPlanePath fails due to an issue with Math::BigInt::Lite on perl530, will open separate PR for this.

@stigtsp stigtsp merged commit b83e3e2 into NixOS:master Jan 31, 2021
@stigtsp stigtsp mentioned this pull request Jan 31, 2021
Merged
10 tasks
@edef1c edef1c deleted the math-planepath-129 branch January 31, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edef1c @SuperSandro2000 @stigtsp