Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: Enable CONFIG_UNICODE to support casefolding #111163

Merged
merged 1 commit into from Mar 1, 2021
Merged

linux: Enable CONFIG_UNICODE to support casefolding #111163

merged 1 commit into from Mar 1, 2021

Conversation

varris1
Copy link
Contributor

@varris1 varris1 commented Jan 29, 2021

Required to mount filesystems with casefold enabled. Fixes #109432

Motivation for this change

Without this option, the user is not able to mount filesystems with casefolding enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@varris1
linux: Enable CONFIG_UNICODE to support casefold
35b0fd4 
Required to mount filesystems with casefold enabled. Fixes #109432
@roblabla
Copy link
Contributor

roblabla commented Feb 27, 2021 •
edited

I've been sailing nixos with a custom linux kernel build that enables that config with zero issues for the past month or so (I'm using it to store windows headers in a case-insensitive folder to facilitate cross-compilation).

Ubuntu has this flag enabled: https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/groovy/tree/debian.master/config/config.common.ubuntu#n10682

So does fedora: https://src.fedoraproject.org/rpms/kernel/blob/rawhide/f/kernel-x86_64-fedora.config#_6756

@NeQuissimus
Copy link
Member

@ofborg test kernel-latest kernel-lts latestKernel.login kernel-latest-ath-user-regd latestKernel.hardened

@NeQuissimus NeQuissimus merged commit 662e3b8 into NixOS:master Mar 1, 2021
@varris1 varris1 deleted the config_unicode branch March 1, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
6.topic: kernel 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linuxPackages: CONFIG_UNICODE required to support case folding
5 participants
@varris1 @roblabla @NeQuissimus @veprbl @Janik-Haag