New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] firefox: 84.0.2 -> 85.0; firefox-esr: 78.6.1esr -> 78.7.0esr #111180
Conversation
|
I have no experience backporting rustc, can someone recommend how to proceed? |
(cherry picked from commit 63e8aa5)
8b57e45
to
e826142
Compare
This is just a minimalist approach to make newer Firefox build. I looked at diff to master and picked differences that seemed required. In particular, some of llvm parts weren't picked, as I expected they would make it harder for me to be sure I haven't broken anything else, and they only appeared useful on Clang platforms (no Firefox there).
Again, firefox-esr doesn't even get rebuilt. This version switching is a bit inconsistent with the way we do it for NSS, but somehow... it felt better (?) to write this way. Anyway, I don't mind if someone improves it; I mainly wanted to fix Firefox quickly with minimal risk of breaking other stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- aarch64: verified the build on
aarch64.nixos.community
(EDIT: finished after original post) - x86_64:
nixosTests.firefox
builds, switched my main browser to this build a while ago (X11 NixOS)
|
I was about to merge this, but noticed the Idk what the policy is |
Motivation for this change
https://www.mozilla.org/en-US/firefox/85.0/releasenotes/
Backport #110984
Things done
cc @ajs124 @taku0 @vcunat @lovesegfault