Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] firefox: 84.0.2 -> 85.0; firefox-esr: 78.6.1esr -> 78.7.0esr #111180

Merged
merged 4 commits into from Feb 7, 2021

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 29, 2021

Motivation for this change

https://www.mozilla.org/en-US/firefox/85.0/releasenotes/

Backport #110984

Things done
  • Ran the nixos test for stable and esr
  • Tested on x86_64-linux Wayland with Pipewire
  • Tested on x86_64-linux X11
  • Tested on aarch64

cc @ajs124 @taku0 @vcunat @lovesegfault

@taku0
Copy link
Contributor

taku0 commented Jan 30, 2021

nix-build -I nixpkgs=. -A pkgs.firefox results in ERROR: Rust compiler 1.44.1 is too old.. It requires 1.47.0 or newer.

@mweinelt
Copy link
Member Author

I have no experience backporting rustc, can someone recommend how to proceed?

@lovesegfault
Copy link
Member

Pinging rustc maintainers: @madjar @cstrahan @globin @Havvy

vcunat pushed a commit that referenced this pull request Feb 1, 2021
(cherry picked from commit ee3fca5)
/cc PR #111180.  ESR seems to work fine, so let's not delay it.
(cherry picked from commit 63e8aa5)
This is just a minimalist approach to make newer Firefox build.
I looked at diff to master and picked differences that seemed required.

In particular, some of llvm parts weren't picked, as I expected they
would make it harder for me to be sure I haven't broken anything else,
and they only appeared useful on Clang platforms (no Firefox there).
Again, firefox-esr doesn't even get rebuilt.

This version switching is a bit inconsistent with the way we do it
for NSS, but somehow... it felt better (?) to write this way.
Anyway, I don't mind if someone improves it; I mainly wanted to
fix Firefox quickly with minimal risk of breaking other stuff.
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • aarch64: verified the build on aarch64.nixos.community (EDIT: finished after original post)
  • x86_64: nixosTests.firefox builds, switched my main browser to this build a while ago (X11 NixOS)

@mweinelt
Copy link
Member Author

mweinelt commented Feb 6, 2021

  • x86_64: firefox-wayland builds, run testing it now, but looks to be working (yt, pipewire, cam, mic).

@lovesegfault
Copy link
Member

I was about to merge this, but noticed the Merge branch 'release-20.09' commit, are we okay with merging these commits back?

Idk what the policy is

@mweinelt mweinelt merged commit 2875bc9 into NixOS:release-20.09 Feb 7, 2021
@mweinelt mweinelt deleted the 20.09/firefox branch February 7, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants