Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] brave: 1.18.75 -> 1.19.88 #111130

Merged
merged 6 commits into from Jan 30, 2021
Merged

[20.09] brave: 1.18.75 -> 1.19.88 #111130

merged 6 commits into from Jan 30, 2021

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Some Brave versions update Chromium and thus have Chromium security updates. Sync again with master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk and others added 6 commits January 29, 2021 09:08
@danieldk
brave: 1.18.75 -> 1.18.77
4848ad3 
Changelog:
https://community.brave.com/t/release-channel-1-18-77/191009
(cherry picked from commit e2a9d90)
@danieldk
brave: add update script
e6e7f38 
The Brave package often seems to get very outdated. This is bad for a
browser, where vulnerabilities are high impact.

This change adds an update script, so that r-ryantm will suggest
updates. We find the latest version using their Debian package
database (since we are using the Debian package anyway).

(cherry picked from commit 4d9d826)
@bbjubjub2494 @danieldk
brave: test rpath in installCheck
337a746 
This check helps with making sure that we provide all the required
shared libraries to brave. If something is missing, the command will get
ENOENT, otherwise it should terminate normally.

(cherry picked from commit 051389e)
@r-ryantm @danieldk
brave: 1.18.77 -> 1.18.78
f7a5963 
(cherry picked from commit ae9f18e)
@r-ryantm @danieldk
brave: 1.18.78 -> 1.19.86
5b8db89 
(cherry picked from commit 3fd5177)
@r-ryantm @danieldk
brave: 1.19.86 -> 1.19.88
d91082f 
(cherry picked from commit 36c01a5)
@ofborg ofborg bot requested review from uskudnik and rht January 29, 2021 08:35
@danieldk
Copy link
Contributor Author

Merging to get security fixes to 20.09 users.

@danieldk danieldk merged commit 3bffd38 into NixOS:release-20.09 Jan 30, 2021
@danieldk danieldk deleted the brave-20.09-backports branch January 30, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uskudnik uskudnik Awaiting requested review from uskudnik

@rht rht Awaiting requested review from rht

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @bbjubjub2494 @r-ryantm