Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycloak: 11.0.3 -> 12.0.2 #111132

Merged
merged 1 commit into from Jan 30, 2021
Merged

keycloak: 11.0.3 -> 12.0.2 #111132

merged 1 commit into from Jan 30, 2021

Conversation

greizgh
Copy link
Contributor

@greizgh greizgh commented Jan 29, 2021

Motivation for this change

This updates keycloak to the latest available version.
The download URL has changed (see download page)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ngerstle @talyz

@ofborg ofborg bot requested review from ngerstle and talyz January 29, 2021 09:03
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111132 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • keycloak

SuperSandro2000
SuperSandro2000 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM. Does it have any breaking changes?

@greizgh
Copy link
Contributor Author

greizgh commented Jan 29, 2021

diff LGTM. Does it have any breaking changes?

I don't think so, upgrade documentation only mention new features/options.
On an existing deployment, I switched to this new version without any issue.

talyz
talyz approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good and the tests pass.

@talyz talyz added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 29, 2021
@SuperSandro2000 SuperSandro2000 merged commit b8b14f2 into NixOS:master Jan 30, 2021
This was referenced Feb 20, 2021
Merged
Closed
@talyz talyz added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ngerstle ngerstle Awaiting requested review from ngerstle

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greizgh @SuperSandro2000 @talyz