Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyqtwebengine: 5.15.0 -> 5.15.2 #111131

Merged
merged 1 commit into from Feb 4, 2021
Merged

pythonPackages.pyqtwebengine: 5.15.0 -> 5.15.2 #111131

merged 1 commit into from Feb 4, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 29, 2021

Motivation for this change

This package should be in sync with QtWebEngine, which is at 5.15.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj requested a review from a user January 29, 2021 08:17
@SuperSandro2000
Copy link
Member

Should we add a comment to QtWebEngine that this package should be updated, too? Maybe we could also re-use the version or throw an assert if the versions do not match.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 29, 2021

Should we add a comment to QtWebEngine that this package should be updated, too? Maybe we could also re-use the version or throw an assert if the versions do not match.

A comment would be enough: it's not a hard requirement. Given the libraries are developed by two independent entities they may not be released simultaneously and an assert in pyqtwebengine could slow the update of qtwebengine, possibly with important security fixes. So, probably not a good idea.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111131 run on x86_64-linux 1

16 packages built:
  • anki
  • ankisyncd
  • calibre (calibre-py3)
  • calibre-py2
  • cq-editor
  • frescobaldi
  • mnemosyne
  • python37Packages.pyqtwebengine
  • python37Packages.spyder
  • python37Packages.spyder_3
  • python38Packages.pyqtwebengine
  • spyder (python38Packages.spyder)
  • python38Packages.spyder_3
  • python39Packages.pyqtwebengine
  • qutebrowser
  • webmacs

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 29, 2021

I'm not sure where to put a comment because the sources of Qt packages are generated.
Maybe in the README.md, but I'm not sure it's appropriate.

@ghost
Copy link

ghost commented Jan 29, 2021

This package should be in sync with QtWebEngine

Do you have a source for that? I thought I read somewhere that new versions of PyQtWebEngine should be applied, even when QtWebEngine hasn't been updated yet.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 29, 2021

No, you probably know more than me: I should have said that using an older pyqtwebengine can cause issues.
The qutebrowser changelog mentions this:

When QtWebEngine has been updated but PyQtWebEngine hasn't yet, the dark mode settings might stop working. As a (currently undocumented) escape hatch, this version adds a QUTE_DARKMODE_VARIANT=qt_515_2 environment variable which can be set to get the correct behavior in (transitive) situations like this.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111131 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • cq-editor
  • frescobaldi
1 package failed to build and already failed to build on hydra master:
6 packages built:
  • anki
  • python37Packages.pyqtwebengine
  • python38Packages.pyqtwebengine
  • python39Packages.pyqtwebengine
  • qutebrowser
  • webmacs

@dotlambda dotlambda merged commit 53885f7 into NixOS:master Feb 4, 2021
rnhmjoj added a commit to rnhmjoj/nixpkgs that referenced this pull request Feb 4, 2021
@rnhmjoj
pythonPackages.pyqtwebengine: 5.15.0 -> 5.15.2 (NixOS#111131)
4fe8cf0 
(cherry picked from commit 53885f7)
@rnhmjoj rnhmjoj mentioned this pull request Feb 4, 2021
Merged
9 tasks
@rnhmjoj rnhmjoj deleted the pyqtweb branch July 10, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @SuperSandro2000 @dotlambda