Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.npyscreen: init at 4.10.5 #111157

Merged
merged 1 commit into from Jan 31, 2021
Merged

python3Packages.npyscreen: init at 4.10.5 #111157

merged 1 commit into from Jan 31, 2021

Conversation

jollheef
Copy link
Member

@jollheef jollheef commented Jan 29, 2021

Motivation for this change

Adds npyscreen: framework for developing console applications using Python and curses.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 29, 2021

One issue here is that the last release of npyscreen was made over 5 years ago.

If it's a dependency of something else then the upstream of the consumers should be poked to migrate to urwid or Python Prompt Toolkit which are both active projects.

@jollheef
Copy link
Member Author

Yes, the last release was made over 5 years ago, however, there are still lots of projects that depend on it.

So it's better to have it rather than abandon them of support until they will migrate.

@SuperSandro2000
Copy link
Member

So it's better to have it rather than abandon them of support until they will migrate.

nixpkgs is not really mean to have every python package. Commonly used packages, callable script and dependencies of other software are usually not a problem.

@jollheef
Copy link
Member Author

Sure it's not, but right now I'm working on pushing some software to nixpkgs, and npyscreen is required for.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111157 run on x86_64-darwin 1

3 packages built:
  • python37Packages.npyscreen
  • python38Packages.npyscreen
  • python39Packages.npyscreen

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111157 run on x86_64-linux 1

3 packages built:
  • python37Packages.npyscreen
  • python38Packages.npyscreen
  • python39Packages.npyscreen

@SuperSandro2000 SuperSandro2000 merged commit 09feb4b into NixOS:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants