Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_rocm: 4.0.0 -> 4.0.1 #111171

Merged
merged 1 commit into from Feb 1, 2021
Merged

llvmPackages_rocm: 4.0.0 -> 4.0.1 #111171

merged 1 commit into from Feb 1, 2021

Conversation

danieldk
Copy link
Contributor

Motivation for this change

ROCm 4.0.1 has been released:

https://rocmdocs.amd.com/en/latest/Current_Release_Notes/Current-Release-Notes.html#amd-rocm-release-notes-v4-0-1

According to the notes, this release adds support for RHEL 8.3. The only changed package is in their LLVM fork, but it seems that the changes are not related to RHEL 8.3, so they might be useful to have.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111171 run on x86_64-linux 1

7 packages built:
  • luxcorerender
  • rocclr
  • rocm-comgr
  • rocm-device-libs
  • rocm-opencl-icd
  • rocm-opencl-runtime
  • rocm-runtime

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

rocclr:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'set(ROCCLR_EXPORTS_FILE "${CMAKE_CURRENT_BINARY_DIR}/amdrocclr_staticTargets.cmake")' doesn't match anything in file 'CMakeLists.txt'
substituteStream(): WARNING: pattern 'find_library( OpenCL REQUIRED' doesn't match anything in file 'CMakeLists.txt'

Please check the offending substituteInPlace for typos or changes in source.

Flakebi
Flakebi approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. OpenCL samples are still working.

Result of nixpkgs-review pr 111171 run on x86_64-linux 1

7 packages built:
  • luxcorerender
  • rocclr
  • rocm-comgr
  • rocm-device-libs
  • rocm-opencl-icd
  • rocm-opencl-runtime
  • rocm-runtime

@danieldk danieldk merged commit 8922094 into NixOS:master Feb 1, 2021
@danieldk danieldk deleted the rocm-4.0.1 branch February 1, 2021 10:55
@acowley
Copy link
Contributor

acowley commented Feb 2, 2021

All good on the overlay side, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@acowley acowley Awaiting requested review from acowley

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @SuperSandro2000 @acowley @Flakebi