mkgmap: 4565 → 4600 #111182
mkgmap: 4565 → 4600 #111182
Conversation
| inherit sha256; | ||
| url = "https://svn.mkgmap.org.uk/mkgmap/mkgmap/trunk"; | ||
| rev = version; | ||
| src = fetchurl { |
There was a problem hiding this comment.
I think we should use fetchzip here.
There was a problem hiding this comment.
The main difference between fetchurl and fetchzip is in how they store the contents. fetchurl will store the unaltered contents of the URL within the Nix store. fetchzip on the other hand will decompress the archive for you, making files and directories directly accessible in the future.
@SuperSandro2000 why? what is the main reason to choose fetchzip over fetchurl in general?
There was a problem hiding this comment.
with fetchzip you do not need to manually uncrompress the files.
There was a problem hiding this comment.
With fetchurl you do not need to manually uncompress as well.
What I see is:
... This is primarily useful for dynamically generated archives, such as GitHub's /archive URLs, where the unpacked content of the zip file doesn't change, but the zip file itself may (e.g. due to minor changes in the compression algorithm, or changes in timestamps).
So fetchzip is kind of workaround for some cases, where fetchurl doesn't work properly due to mentioned above reasons.
| inherit sha256; | ||
| url = "https://svn.mkgmap.org.uk/mkgmap/splitter/trunk"; | ||
| rev = version; | ||
| src = fetchurl { |
There was a problem hiding this comment.
I think we should use fetchzip here.
Motivation for this change
fetchsvntofetchurlpassthru.updateScriptThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)