Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hwi: reintroduce dropped dependencies #111183

Merged
merged 1 commit into from Jan 29, 2021
Merged

pythonPackages.hwi: reintroduce dropped dependencies #111183

merged 1 commit into from Jan 29, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 29, 2021 •
edited

Motivation for this change

partial revert of 863d89b

@SuperSandro2000 : Any particular reason why you removed these deps earlier?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 : Any particular reason why you removed these deps earlier?

Because upstream does not list them in their setup.py https://github.com/bitcoin-core/HWI/blob/1.2.1/setup.py or any extra_requires.

@prusnak
Copy link
Member Author

prusnak commented Jan 29, 2021 •
edited

Because upstream does not list them in their setup.py

HWI is common interface for accessing hardware wallets by different vendors. These deps need to be included, otherwise HWI is not able to work with these.

@prusnak prusnak merged commit ec36c2a into NixOS:master Jan 29, 2021
@prusnak prusnak deleted the hwi branch January 29, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @SuperSandro2000