Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift: mark as broken and insecure #111211

Merged
merged 2 commits into from Jan 31, 2021
Merged

swift: mark as broken and insecure #111211

merged 2 commits into from Jan 31, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

closes #106245

There's two separate commits because on 20.09, it should only be marked as insecure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @vy-let @mroi

@dotlambda
swift: mark as insecure
26cde7b
@dotlambda
swift: mark as broken
3780fbe 
No successful build on Hydra since 2020-12-23.
@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 29, 2021
erictapen
erictapen approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also verified that swift is a cache miss on nixos-unstable.

@danieldk danieldk merged commit db73e7a into NixOS:master Jan 31, 2021
@dotlambda dotlambda deleted the swift-broken-insecure branch January 31, 2021 13:08
@erictapen
Copy link
Member

Backport for marking as insecure in 15252b4.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@erictapen erictapen erictapen approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 97: swift-5.1.1: 1 advisory [7.5]
3 participants
@dotlambda @erictapen @danieldk