libxslt: use python3 on darwin #111212
libxslt: use python3 on darwin #111212
Conversation
ofborg
bot
added
6.topic: darwin
|
/rebase-staging |
github-actions
bot
force-pushed
the
ivan/libxslt-py3
branch
from
ded1bb1 to
a95a245
Compare
See NixOS#63174 where the condition was first introduced.
bobrik
force-pushed
the
ivan/libxslt-py3
branch
from
a95a245 to
1293244
Compare
bobrik
force-pushed
the
ivan/libxslt-py3
branch
from
1293244 to
ca3bb64
Compare
| @@ -3710,7 +3710,7 @@ in { | |||
|
|
|||
| libxslt = (toPythonModule (pkgs.libxslt.override { | |||
| pythonSupport = true; | |||
| inherit python; | |||
| python3 = python; | |||
There was a problem hiding this comment.
This looks awkward now, but this is what other packages do in this file.
There was a problem hiding this comment.
A more elegant way would be to remove this line and add disabled to the package. You need to input python and not python3 here because otherwise it would break the package for different python versions.
There was a problem hiding this comment.
A more elegant way would be to remove this line and add disabled to the package.
Like disabledIf (!isPy3k)?
There was a problem hiding this comment.
disabledIf (!isPy3k)
That's for in case the bindings are no longer Python 2 compatible.
There was a problem hiding this comment.
Like disabledIf (!isPy3k)?
in the package: disabled = !isPy3k;.
There was a problem hiding this comment.
The package itself builds ok with python2 (it was the default on darwin after all), why disable it?
There was a problem hiding this comment.
I just answered your question. Packages schools not be null when a specific platform is not supported.
Motivation for this change
See #63174 where the condition was first introduced. In #77610 it was dropped for libxml2
Not having python2 helps with #105026.
cc @NixOS/darwin-maintainers
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)