Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter: 1.22.5 -> 1.22.4 #111187

Merged
merged 2 commits into from Jan 30, 2021
Merged

flutter: 1.22.5 -> 1.22.4 #111187

merged 2 commits into from Jan 30, 2021

Conversation

thiagokokada
Copy link
Contributor

Motivation for this change

PR #109477 bumped Flutter from 1.22.0 -> 1.22.4, and afterwards from 1.22.4 -> 1.22.5. Everything seems to work well (flutter doctor works), but trying to run flutter create results in:

$ flutter create project_test
...
Because every version of flutter from sdk depends on sky_engine any from sdk which is forbidden, flutter from sdk is forbidden.
So, because project_test depends on flutter any from sdk, version solving failed.
pub get failed (server unavailable) -- attempting retry 1 in 1 second...
Because every version of flutter from sdk depends on sky_engine any from sdk which is forbidden, flutter from sdk is forbidden.
So, because project_test depends on flutter any from sdk, version solving failed.
pub get failed (server unavailable) -- attempting retry 2 in 2 seconds...
Because every version of flutter from sdk depends on sky_engine any from sdk which is forbidden, flutter from sdk is forbidden.
So, because project_test depends on flutter any from sdk, version solving failed.
pub get failed (server unavailable) -- attempting retry 3 in 4 seconds...
Because every version of flutter from sdk depends on sky_engine any from sdk which is forbidden, flutter from sdk is forbidden.
So, because project_test depends on flutter any from sdk, version solving failed.
pub get failed (server unavailable) -- attempting retry 4 in 8 seconds...
Because every version of flutter from sdk depends on sky_engine any from sdk which is forbidden, flutter from sdk is forbidden.
So, because project_test depends on flutter any from sdk, version solving failed.

I will try to investigate later on, but for now let's unbreak Flutter by unbumping it. But let's keep some of the changes after bump just to not break backwards compatibility thrice (even if the removal of depsSha256 is a small breaking change).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor Author

@SuperSandro2000 ?

@ofborg ofborg bot requested a review from ericdallo January 29, 2021 20:53
@SuperSandro2000
Copy link
Member

Because every version of flutter from sdk depends on sky_engine any from sdk which is forbidden, flutter from sdk is forbidden.
So, because project_test depends on flutter any from sdk, version solving failed.

What is this error message. I read it 5 times and still don't understand it.

@thiagokokada
Copy link
Contributor Author

Because every version of flutter from sdk depends on sky_engine any from sdk which is forbidden, flutter from sdk is forbidden.
So, because project_test depends on flutter any from sdk, version solving failed.

What is this error message. I read it 5 times and still don't understand it.

I also don't know, but my suspect is that the sky_engine dependency from Flutter is conflicting with sky_engine dependency of the project itself (don't know why this is happening).

But it is quite easy to reproduce, go to master and do flutter create test_project.

@SuperSandro2000
Copy link
Member

But it is quite easy to reproduce, go to master and do flutter create test_project.

I have zero knowledge about flutter so I can't help you in any meaningful way.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111187 run on x86_64-linux 1

2 packages built:
  • flutter (flutterPackages.stable)
  • hover

@SuperSandro2000
Copy link
Member

@ericdallo it would be nice if you could take a look at the refactor.

other than that I the change looks fine to me but I can't tell if it is the right decision.

ericdallo
ericdallo approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the failing derivation LGTM

@SuperSandro2000 SuperSandro2000 merged commit b2b193a into NixOS:master Jan 30, 2021
This was referenced Jan 31, 2021
Merged
Closed
@thiagokokada thiagokokada deleted the revert-flutter-bump branch December 8, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ericdallo ericdallo ericdallo approved these changes

@babariviere babariviere Awaiting requested review from babariviere

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiagokokada @SuperSandro2000 @ericdallo