Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fonttools: 4.18.2 -> 4.19.1 #111196

Merged
1 commit merged into from Feb 8, 2021
Merged

pythonPackages.fonttools: 4.18.2 -> 4.19.1 #111196

1 commit merged into from Feb 8, 2021

Conversation

sternenseemann
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111196 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • gscan2pdf
  • odpdown
39 packages built:
  • noto-fonts-emoji
  • python37Packages.afdko
  • python37Packages.booleanoperations
  • python37Packages.defcon
  • python37Packages.fontmath
  • python37Packages.fontparts
  • python37Packages.fontpens
  • python37Packages.fonttools
  • python37Packages.mutatormath
  • python37Packages.nototools
  • python37Packages.psautohint
  • python37Packages.ufoprocessor
  • python38Packages.afdko
  • python38Packages.booleanoperations
  • python38Packages.defcon
  • python38Packages.fontmath
  • python38Packages.fontparts
  • python38Packages.fontpens
  • python38Packages.fonttools
  • python38Packages.mutatormath
  • python38Packages.nototools
  • python38Packages.psautohint
  • python38Packages.ufoprocessor
  • python39Packages.afdko
  • python39Packages.booleanoperations
  • python39Packages.defcon
  • python39Packages.fontmath
  • python39Packages.fontparts
  • python39Packages.fontpens
  • python39Packages.fonttools
  • python39Packages.mutatormath
  • python39Packages.nototools
  • python39Packages.psautohint
  • python39Packages.ufoprocessor
  • rictydiminished-with-firacode
  • scfbuild
  • visidata
  • xits-math
  • xquartz

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

xquartz:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '@FONTCONFIG_FILE@' doesn't match anything in file '/nix/store/fgmn5ijavbcd4px57lmn6qgg0ycd9p8a-xquartz-1.18.4/etc/X11/xinit/xinitrc'

Please check the offending substituteInPlace for typos or changes in source.

@ghost ghost merged commit 80d9064 into NixOS:master Feb 8, 2021
@sternenseemann sternenseemann deleted the fonttools-4.19.1 branch February 8, 2021 12:33
@sternenseemann sternenseemann restored the fonttools-4.19.1 branch July 24, 2021 13:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @SuperSandro2000