websockets/cookies: specify wpt_flags=https for wss variants #27397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, wss variants will fail because they are not served over https. And an insecure page cannot set a secure cookie. As a solution, we load those variants with wpt_flags=https. It will force the test to be loaded over https. 006.https.html was a previous way of solving the same issue. We can now get rid of it, and simply use 006.html with the correct variant set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, wss variants will fail because they are not served over
https. And an insecure page cannot set a secure cookie.
As a solution, we load those variants with wpt_flags=https. It will
force the test to be loaded over https.
006.https.html was a previous way of solving the same issue. We can now
get rid of it, and simply use 006.html with the correct variant set.