Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal-ctags: bump to p5.9.20210124.0 from git tags #111216

Merged
merged 3 commits into from Feb 17, 2021
Merged

universal-ctags: bump to p5.9.20210124.0 from git tags #111216

merged 3 commits into from Feb 17, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Jan 29, 2021 •
edited

Motivation for this change

Switching to python2 to python3 seems like a reasonable thing to do.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobrik bobrik force-pushed the ivan/universal-ctags-unused branch from 10b560b to 91df29c Compare January 29, 2021 22:34
@bobrik bobrik mentioned this pull request Jan 29, 2021
Merged
21 tasks
@ofborg ofborg bot requested a review from mimame January 29, 2021 23:00
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111216 run on x86_64-linux 1

2 packages built:
  • global
  • universal-ctags

@bobrik bobrik force-pushed the ivan/universal-ctags-unused branch 3 times, most recently from fa26ea0 to 6ecdf1b Compare January 30, 2021 01:44
@tomberek
Copy link
Contributor

tomberek commented Jan 30, 2021 •
edited

Result of nixpkgs-review pr 111216 run on x86_64-linux 1

2 packages failed to build:
  • global
  • universal-ctags
``` $ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/tom/.cache/nixpkgs-review/pr-111216-1/build.nix error: --- Error --- nix-daemon builder for '/nix/store/49f4p158nqdpdk305r7b508g36w3z54i-universal-ctags-5.9.20210124.0.drv' failed with exit code 2; last 10 log lines: stderr passed

Failed tests

lregex-kind-letter/stdout-compare
lregex-kind-letter/stderr-compare
lregex-kind-name/stdout-compare
lregex-kind-name/stderr-compare

make: *** [Makefile:6038: tmain] Error 1
error: --- Error --- nix-daemon
1 dependencies of derivation '/nix/store/x0pv4kabvzld8z77ir35cfb7s1z8ch5i-global-6.6.5.drv' failed to build
error: --- Error ----------------------------------------------------------------------------------------- nix
2 dependencies of derivation '/nix/store/w80ib4kn7wm3zavbkvvzsh18iw8fhlcj-env.drv' failed to build

Link to currently reviewing PR:
#111216

2 packages failed to build:
global universal-ctags

error: --- Error ----------------------------------------------------------------------------------------- nix
build log of '/nix/store/x0pv4kabvzld8z77ir35cfb7s1z8ch5i-global-6.6.5.drv' is not available
$ nix-shell /home/tom/.cache/nixpkgs-review/pr-111216-1/shell.nix

</details>

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111216 run on x86_64-linux 1

2 packages failed to build and are new build failures:

@bobrik bobrik force-pushed the ivan/universal-ctags-unused branch from 6ecdf1b to a67cc87 Compare February 1, 2021 01:13
@bobrik
Copy link
Contributor Author

bobrik commented Feb 1, 2021

Pushed another commit to downgrade the version to make aarch64-linux build. The issue is very similar to this one:

The common thing being ax_prog_cc_for_build.m4 and the error log message. I don't know how to fix it properly.

cc @flokli

@bobrik
Copy link
Contributor Author

bobrik commented Feb 1, 2021

Huh, the tests fail in ofborg:

Testing lregex-kind-letter
------------------------------------------------------------
stdout                                                      failed (diff: /build/source/Tmain/lregex-kind-letter.d/stdout-diff.txt)
stderr                                                      failed (diff: /build/source/Tmain/lregex-kind-letter.d/stderr-diff.txt)
..
Testing lregex-kind-name
------------------------------------------------------------
stdout                                                      failed (diff: /build/source/Tmain/lregex-kind-name.d/stdout-diff.txt)
stderr                                                      failed (diff: /build/source/Tmain/lregex-kind-name.d/stderr-diff.txt)

But pass for me locally (on both aarch64-linux and aarch64-darwin):

Testing lregex-kind-letter
------------------------------------------------------------
stdout                                                      passed
stderr                                                      passed
...
Testing lregex-kind-name
------------------------------------------------------------
stdout                                                      passed
stderr                                                      passed

How can I debug this?

@bobrik
universal-ctags: downgrade to p5.9.20201206.0
507b96e 
Newer versions fail on aarch64-linux:

```
  checking for aarch64-unknown-linux-gnu-gcc... aarch64-unknown-linux-gnu-gcc
  checking whether the compiler supports GNU C... yes
  checking whether aarch64-unknown-linux-gnu-gcc accepts -g... yes
  checking for aarch64-unknown-linux-gnu-gcc option to enable C11 features... (cached) none needed
  checking whether aarch64-unknown-linux-gnu-gcc understands -c and -o together... yes
  checking dependency style of aarch64-unknown-linux-gnu-gcc... none
  checking whether the C compiler works... no
  configure: error: in `/build/source':
  configure: error: C compiler cannot create executables
  See `config.log' for more details
```

The following PR is likely culprit:

* universal-ctags/ctags#2747
@bobrik
Copy link
Contributor Author

bobrik commented Feb 16, 2021

Found why it was working for me locally: sandboxing was off. The reason why tests were failing with sandboxing enabled was usage of hardcoded /bin/echo in tests:

@SuperSandro2000, builds are green now, this is ready to go now.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111216 run on x86_64-darwin 1

2 packages built:
  • global
  • universal-ctags

@SuperSandro2000 SuperSandro2000 merged commit f26b6bb into NixOS:master Feb 17, 2021
@bobrik bobrik deleted the ivan/universal-ctags-unused branch March 6, 2021 22:11
@collares collares mentioned this pull request Dec 23, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@mimame mimame Awaiting requested review from mimame

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobrik @SuperSandro2000 @tomberek