Skip to content

Commit 9a177f0

Browse files
committedJan 29, 2021
PlayerDatabaseFiles: Fix segfault while saving a player
Corrects a typo introduced in 5e9dd16
1 parent 9c91cbf commit 9a177f0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

Diff for: ‎src/database/database-files.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ void PlayerDatabaseFiles::serialize(RemotePlayer *p, std::ostream &os)
121121
args.setS32("version", 1);
122122
args.set("name", p->m_name);
123123

124-
// This should not happen
125124
PlayerSAO *sao = p->getPlayerSAO();
126-
assert(sao);
125+
// This should not happen
126+
sanity_check(sao);
127127
args.setU16("hp", sao->getHP());
128128
args.setV3F("position", sao->getBasePosition());
129129
args.setFloat("pitch", sao->getLookPitch());
@@ -189,7 +189,7 @@ void PlayerDatabaseFiles::savePlayer(RemotePlayer *player)
189189

190190
// Open and serialize file
191191
std::ostringstream ss(std::ios_base::binary);
192-
serialize(&testplayer, ss);
192+
serialize(player, ss);
193193
if (!fs::safeWriteToFile(path, ss.str())) {
194194
infostream << "Failed to write " << path << std::endl;
195195
}

0 commit comments

Comments
 (0)
Please sign in to comment.