Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgccjit: use current gcc version #111166

Merged
merged 1 commit into from Feb 19, 2021
Merged

libgccjit: use current gcc version #111166

merged 1 commit into from Feb 19, 2021
+1 −1

Conversation

collares
Copy link
Member

@collares collares commented Jan 29, 2021 •
edited

Motivation for this change

Gcc was recently upgraded to version 10, but libgccjit still uses gcc 9. I've been using Emacs' feature/native-comp branch with this for a week now and it's working fine.

Things done
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Fits CONTRIBUTING.md.

@collares collares mentioned this pull request Feb 18, 2021
Merged
2 tasks
@adisbladis adisbladis merged commit cf756e5 into NixOS:master Feb 19, 2021
@adisbladis
Copy link
Member

Iirc we were still on gcc8 when libgccjit = gcc9... was added, so it's mostly a historical remnant.

Thanks!

@collares collares deleted the gccjit-update branch February 19, 2021 18:14
@purcell
Copy link
Member

purcell commented Feb 26, 2021

As of this change, I'm seeing compilation failures building libgccjit 10 on Darwin:

/nix/store/5y6lcfjghk5kbv4782vi7w79vz60gsyn-bash-4.4-p23/bin/bash ../../gcc-10.2.0/gcc/../install-sh -c -s libgccjit.so.0.0.1 \
  //nix/store/80kgw8spyllzacqbwmr20r9mw7y8xq53-libgccjit-10.2.0/lib/libgccjit.so.0.0.1
strip: error: symbols referenced by indirect symbol table entries that can't be stripped in: /nix/store/80kgw8spyllzacqbwmr20r9mw7y8xq53-libgccjit-10.2.0/lib/_inst.6848_
__NSGetEnviron
__Unwind_Backtrac

which looks like what @antifuchs encountered here. Any idea what the solution is?

@collares
Copy link
Member Author

Does it work if you add langJit to the inherit statement at https://github.com/nixos/nixpkgs/blob/master/pkgs/development/compilers/gcc/10/default.nix#L184, as #94637 did for gcc 9?

@adisbladis adisbladis mentioned this pull request Feb 26, 2021
Merged
10 tasks
@adisbladis
Copy link
Member

I made a PR to fix Darwin: #114451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@collares @adisbladis @purcell