Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boundary: init at 0.1.4 #111151

Merged
merged 1 commit into from Feb 1, 2021
Merged

boundary: init at 0.1.4 #111151

merged 1 commit into from Feb 1, 2021

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Jan 29, 2021 •
edited

Motivation for this change

Draft until some questions are answered on the HashiCorp Discuss Desktop electron edition is still in-progress 馃憤

Init boundary at 0.1.4

https://boundaryproject.io
https://github.com/hashicorp/boundary
(UI https://github.com/hashicorp/boundary-ui)

Ran the dev server, haven't tried ssh-ing using it as my nixos config is a bit broken so I can't easily change firewall rules.

I tried building from source but it's one of those JS/Node built UI + Go deals and it'll only get more complicated once its released with the CLI + the desktop electron version.
The influxdb2 derivation helped but it's still in progress.

It is possible to build the CLI without the UI bundle but I'm 99% sure that's an unintended usecase 馃槄

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 29, 2021
View reviewed changes
pkgs/tools/networking/boundary/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/boundary/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/boundary/default.nix Outdated Show resolved Hide resolved
@06kellyjac 06kellyjac force-pushed the boundary branch 2 times, most recently from ff6a1b2 to 02ebdec Compare February 1, 2021 11:45
@06kellyjac 06kellyjac marked this pull request as ready for review February 1, 2021 12:08
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111151 run on x86_64-darwin 1

1 package built:
  • boundary

@SuperSandro2000 SuperSandro2000 merged commit 3402175 into NixOS:master Feb 1, 2021
@06kellyjac 06kellyjac deleted the boundary branch February 1, 2021 23:45
@06kellyjac 06kellyjac mentioned this pull request Feb 2, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @SuperSandro2000