Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.minimap-vim: init at 2021-01-04 #111150

Merged
merged 3 commits into from Jan 29, 2021
Merged

Conversation

teto
Copy link
Member

@teto teto commented Jan 29, 2021

adds a minimap in vim, quite cool IMO

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tnias
Copy link
Contributor

tnias commented Jan 29, 2021

If I manually put code-minimap into the PATH, it works just fine.

If I just add it to vim as a plugin, I get the following error. I assume the substitution did not work as expected.

/nix/store/...-vimplugin-minimap-vim-2021-01-04/share/vim-plugins/minimap-vim/bin/minimap_generator.sh: line 19: code-minimap: command not found^@

To reproduce the error: Open vim and run :Minimap.

complement minimap-vim install (it checks that it's in path)
@teto
Copy link
Member Author

teto commented Jan 29, 2021

thanks for trying, I had added code-minimap in neovim's PATH as a first approach which is why I had not caught the issue.
I've patched that executable too, seems to work here.

@tnias
Copy link
Contributor

tnias commented Jan 29, 2021

The new version works. 👍

If I am in NORMAL mode on the code side and scroll very fast, it starts lagging. Fast scrolling in INSERT mode does not cause lagging. But I assume this is an issue with the plugin not the packaging.

pkgs/misc/vim-plugins/overrides.nix Outdated Show resolved Hide resolved
pkgs/misc/vim-plugins/overrides.nix Outdated Show resolved Hide resolved
teto and others added 2 commits January 29, 2021 18:21
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111150 run on x86_64-darwin 1

1 package built:
  • spacevim

@SuperSandro2000 SuperSandro2000 merged commit 61fef16 into NixOS:master Jan 29, 2021
@teto teto deleted the minimap branch January 29, 2021 20:51
@teto
Copy link
Member Author

teto commented Jan 29, 2021

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants