[URL] Add tests for the distinct percent-encode sets #27742
Conversation
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
url/resources/urltestdata.json
Outdated
| "host": "host", | ||
| "hostname": "host", | ||
| "href": "wss://%20!%22$%&'()*+,-.%3B%3C%3D%3E%40%5B%5D%5E_%60%7B%7C%7D~@host/", | ||
| "origin": "null", |
There was a problem hiding this comment.
jsdom/whatwg-url says this should be wss://host
url/resources/urltestdata.json
Outdated
| "host": "host", | ||
| "hostname": "host", | ||
| "href": "wss://joe:%20!%22$%&'()*+,-.%3A%3B%3C%3D%3E%40%5B%5D%5E_%60%7B%7C%7D~@host/", | ||
| "origin": "null", |
There was a problem hiding this comment.
jsdom/whatwg-url says this should be wss://host
|
They have an origin per https://url.spec.whatwg.org/#origin. Thanks for working on this @alwinb! Are you also planning to file browser bugs? I suspect some of these might be tracked already, but it might help to have a fresh one with all the relevant data in it. |
|
No you're right, the origin should be |
|
@annevk I am a bit uneasy about filing browser bugs. I wonder if more will come up while I study this, and there are some issues that look like they will trigger additional small changes to the encode sets. I kind of prefer to send a single bug report to them rather than several with changes in a row. Maybe that's being too careful, but still... |
|
Thanks for the update, I think that's fine in this case. |
This adds a number of test cases to test the distinct percent-encode sets as specified in the Percent-encoded bytes section of the WHATWG URL Standard.