webrtc: update WPT for addIceCandidate(null) #27605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 12, 2021
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2690791
branch
2 times, most recently
from
c519c79
to
6181834
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2690791
branch
2 times, most recently
from
7b3a095
to
cafd1a4
Compare
|
@jan-ivar /webrtc/RTCDTMFSender-ontonechange.https.html seems to flake again in FF. Not a bad flake at least |
|
same flakyness as #27336 -- there is a pattern |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2690791
branch
2 times, most recently
from
54174a9
to
afea32a
Compare
BUG=chromium:978582 Change-Id: I4f6e93bd900ad8f5caf55143ded48280a6b26475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690791 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#857066}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2690791
branch
from
afea32a
to
d0bc554
Compare
|
The stability issues are believed to be existing flakes. Can we manually merge this @foolip ? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=chromium:978582
Change-Id: I4f6e93bd900ad8f5caf55143ded48280a6b26475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690791
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857066}