URLPattern: Support unicode characters in group names. #27750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 23, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2713886
branch
3 times, most recently
from
c68485d
to
b754768
Compare
This CL adds support for unicode characters in group names, e.g. `:café`. It allows group names to contain the same characters as javascript identifiers. All other parts of the pattern are still required to be ASCII for now. This change was discussed in this spec issue: whatwg/urlpattern#46 Bug: 1141510 Change-Id: I094e23797ceebab42adbfbac992398643c2c9079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713886 Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#858330}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2713886
branch
from
b754768
to
fbe4585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for unicode characters in group names, e.g.
:café. It allows group names to contain the same characters asjavascript identifiers. All other parts of the pattern are still
required to be ASCII for now.
This change was discussed in this spec issue:
whatwg/urlpattern#46
Bug: 1141510
Change-Id: I094e23797ceebab42adbfbac992398643c2c9079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713886
Reviewed-by: Frank Tang <ftang@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858330}