Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Paint for "new" columns created by OOFs in nested context #27749

Merged
merged 1 commit into from Feb 24, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 23, 2021

In CL:2704649, support was added for OOF elements that fragment beyond
the last existing fragmentainer in a nested fragmentation context.
Instead of actually creating new columns for these, we add them to the
last existing column with additional inline offset.

In order for paint to work in this case, we needed to ensure that
these fragments retrieve the correct incoming break token in
NGFragmentChildIterator::UpdateSelfFromFragment().

Bug: 1079031
Change-Id: Ib6b7400a5b898431303fe56526d1abced0343a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713259
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857315}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

In CL:2704649, support was added for OOF elements that fragment beyond
the last existing fragmentainer in a nested fragmentation context.
Instead of actually creating new columns for these, we add them to the
last existing column with additional inline offset.

In order for paint to work in this case, we needed to ensure that
these fragments retrieve the correct incoming break token in
NGFragmentChildIterator::UpdateSelfFromFragment().

Bug: 1079031
Change-Id: Ib6b7400a5b898431303fe56526d1abced0343a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713259
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857315}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants