Properly catch exception so that test can run to end #27752
Conversation
Met WebDriverException and it is not properly catched, and cause an Assertion error in restart_runner, cause the whole test abort early Bug: 27751
wpt-pr-bot
added
infra
wptrunner
There was a problem hiding this comment.
For some additional background, this happens when a new test starts and webdriver attempts to activate the newly-created window but the browser crashes in the middle of the navigation.
The effect is that the uncaught exception goes all the way out to the runner manager and aborts the test loop.
This kind of browser issue should be handled gracefully in the runner.
| try: | ||
| if test.environment != self.last_environment: |
There was a problem hiding this comment.
I wonder if this should be in a separate try/except block before this one, and perhaps results in an "INTERNAL-ERROR" or something? Maybe @jgraham can comment.
There was a problem hiding this comment.
Luke, if this is due to an issue at browser side, then "ERROR" is more appropriate? I tried and did not reproduce this on clank. What does "INTERNAL-ERROR" mean? thanks!
There was a problem hiding this comment.
I think result_from_exception will convert this into INTERNAL-ERROR and I think that's the correct result for this case (since it's an error not assoicated with the specific test code).
| try: | ||
| if test.environment != self.last_environment: |
There was a problem hiding this comment.
I think result_from_exception will convert this into INTERNAL-ERROR and I think that's the correct result for this case (since it's an error not assoicated with the specific test code).
Met WebDriverException and it is not properly catched,
and cause an Assertion error in restart_runner, cause
the whole test abort early
Bug: 27751