Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparency of houses, etc., rendered too dark #8735

Closed
2TallTyler opened this issue Feb 23, 2021 · 4 comments
Closed

Transparency of houses, etc., rendered too dark #8735

2TallTyler opened this issue Feb 23, 2021 · 4 comments

Comments

@2TallTyler
Copy link
Member

Version of OpenTTD

Not present in 1.10.3, but found in a build of master when the latest commit was c93c9c0. I have not investigated when exactly this began.

Expected result

Transparent objects like houses look like this:
shadow_current

Actual result

They look like this, much darker and with ugly noise:
shadow_new

I assume this is not intentional. 🙂

Steps to reproduce

  1. View houses in transparency mode
@James103
Copy link
Contributor

Are you running OpenTTD using OpenGL (openttd -v sdl-opengl)?

@TrueBrain
Copy link
Member

Happens with 8bpp-optimized, no matter what your driver is. Will bisect :)

@TrueBrain
Copy link
Member

TrueBrain commented Feb 23, 2021 •
edited

Well, I went down a weird rabbit hole there, but what you are seeing is the 32bpp blitter vs the 8bpp blitter. There are less "grey" in the 8bpp, so it quickly becomes weirdly dark .. has always been that way.

OpenGL now starts in 8bpp by default, if there is no need for 32bpp. This is a change into how it was before, and that is what you are seeing.

Another argument to make 32bpp default :)

@2TallTyler
Copy link
Member Author

Another argument to make 32bpp default :)

+1 from me. But since this isn't a bug, I'll close the issue.

@2TallTyler 2TallTyler mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TrueBrain @James103 @2TallTyler