Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TablesNG] Fix wikipedia, rowspan problem #27746

Merged
merged 1 commit into from Feb 23, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 23, 2021

FindNextFreeColumn assumed rowspan cells were ascending by
start column. This was not the case.

Fix: sort rowspan cells at the end of every row.

Bug: 1180592
Change-Id: I8a14a06ed68849346e84b0af4e851e4099aae011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2716104
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856844}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

FindNextFreeColumn assumed rowspan cells were ascending by
start column. This was not the case.

Fix: sort rowspan cells at the end of every row.

Bug: 1180592
Change-Id: I8a14a06ed68849346e84b0af4e851e4099aae011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2716104
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856844}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants