Call CheckCanStartAnimationOnCompositor at paint #27747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 23, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2713344
branch
5 times, most recently
from
68c005e
to
9fe5526
Compare
Note: this is for background-color animation only, not for other properties. When composite background-color animation, the paint stage collect some parameters such as animated colors for the animation. If this step is successful, then we will paint the element off the main thread. After that, we can have CheckCanStartAnimationOnCompositor returning false and refuse to run the background-color animation on the compositor thread. In this case, the paint of the element off the main thread won't work. So in this CL, we call CheckCanStartAnimationOnCompositor during the paint step. This ensures the consistency of the paint and compositor animation. Bug: 1178987 Change-Id: I737b1e290730637977bc6fcff65cab9b4651aa8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713344 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#858271}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2713344
branch
from
9fe5526
to
4dc7016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is for background-color animation only, not for other
properties.
When composite background-color animation, the paint stage collect
some parameters such as animated colors for the animation. If this
step is successful, then we will paint the element off the main
thread. After that, we can have CheckCanStartAnimationOnCompositor
returning false and refuse to run the background-color animation
on the compositor thread. In this case, the paint of the element
off the main thread won't work.
So in this CL, we call CheckCanStartAnimationOnCompositor during
the paint step. This ensures the consistency of the paint and
compositor animation.
Bug: 1178987
Change-Id: I737b1e290730637977bc6fcff65cab9b4651aa8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713344
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858271}