Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8731: Always use a 32bpp blitter if font anti-aliasing is enabled. #8736

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix #8731: Always use a 32bpp blitter if font anti-aliasing is enabled. #8736

merged 1 commit into from
Feb 23, 2021
+19 −2

Conversation

michicc
Copy link
Member

@michicc michicc commented Feb 23, 2021

Motivation / Problem

OpenGL video drivers now sometimes cause an 8bpp blitter to be used. These can't do font anti-alias.

Description

If any font should be anti-aliased, always use a 32bpp blitter.

Limitations

Most video drivers result in a 32bpp anyway, so no real change for non-OpenGL video drivers.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc
Fix OpenTTD#8731: Always use a 32bpp blitter if font anti-aliasing is…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
38afef6 
… enabled.
TrueBrain
TrueBrain approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just have put 32bpp for all OSes in all situations as preferred blitter .. but sure, why not ;)

Sorry, something went wrong.

@michicc michicc merged commit 46e1331 into OpenTTD:master Feb 23, 2021
@michicc michicc deleted the pr/gl_font_aa branch February 23, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michicc @TrueBrain