Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf5: 1.10.6 -> 1.10.7 #111313

Merged
merged 1 commit into from Feb 18, 2021
Merged

hdf5: 1.10.6 -> 1.10.7 #111313

merged 1 commit into from Feb 18, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

fix CVE-2018-13870, CVE-2018-13869, CVE-2018-17438, and CVE-2018-17435 (see https://github.com/HDFGroup/hdf5/blob/hdf5-1_10_7/release_docs/RELEASE.txt)
I'm not sure if this fixes the vulnerabilities mentioned in #88322.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @tviti @ttuegel @markuskowa

@SuperSandro2000
Copy link
Member

/rebase-staging

@SuperSandro2000
Copy link
Member

Actually I am not sure if this should go through staging but over 500 rebuilds when hydra has issues seems a bit much.

@github-actions github-actions bot changed the base branch from master to staging January 30, 2021 16:40
@markuskowa
Copy link
Member

For security updates one could make an exception and bypass staging. However, nixpkgs-review shows ~900 rebuilds, probably making staging the right call.

@dotlambda
Copy link
Member Author

I'm not sure if this fixes the vulnerabilities mentioned in #88322.

Does anyone know?

@TredwellGit
Copy link
Member

@dotlambda
Copy link
Member Author

Does not fix. https://repology.org/project/hdf5/cves?version=1.12.0

Maybe the maintainers can update to a version > 1.12.0 after this is merged.

@TredwellGit
Copy link
Member

There is no version > 1.12.0.

@risicle
Copy link
Contributor

risicle commented Jan 31, 2021

Yeah I think it's very unlikely it fixes CVE-2020-10809 - decompress.c in the 1.10 branch doesn't seem to have been given a non-trivial update since well before the CVE.

@risicle
Copy link
Contributor

risicle commented Jan 31, 2021

Looking more broadly, I don't think that CVE has been fixed anywhere, even in hdf master.

@dotlambda
Copy link
Member Author

Marking it as insecure will impact a very high number of packages. What should we do?

@dotlambda
Copy link
Member Author

I opened an upstream issue. I think we should merge this and discuss the remaining CVEs in the issue linked above.

@TredwellGit
Copy link
Member

What needs to be done to get this merged?

@SuperSandro2000
Copy link
Member

hdf5 builds locally fine.

Note:

hdf5: Ask if output path lib (4.3M) could be split with outputs = [ ... "lib" ];

@SuperSandro2000 SuperSandro2000 merged commit fcb8923 into NixOS:staging Feb 18, 2021
@dotlambda dotlambda deleted the hdf5-1.10.7 branch February 19, 2021 13:48
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants