Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.extensions.xmlreader: Add internal dependency on dom #111317

Merged
merged 1 commit into from Feb 1, 2021
Merged

php.extensions.xmlreader: Add internal dependency on dom #111317

merged 1 commit into from Feb 1, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jan 30, 2021

Motivation for this change

Fix the xmlreader PHP extension, which was missing its internal dependency on dom.

Fixes #93647

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz mentioned this pull request Jan 30, 2021
Closed
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111317 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • hhvm
  • php73Packages.phpmd
56 packages built:
  • adminer
  • arcanist
  • drush
  • icingaweb2
  • libsForQt5.kcachegrind (libsForQt515.kcachegrind ,plasma5Packages.kcachegrind)
  • libsForQt512.kcachegrind
  • libsForQt514.kcachegrind
  • lsp-plugins
  • matomo
  • matomo-beta
  • nagios
  • nextcloud-news-updater
  • phoronix-test-suite
  • php (php74)
  • php73
  • php73Extensions.xmlreader
  • php73Packages.box
  • php73Packages.composer
  • php73Packages.composer2
  • php73Packages.php-cs-fixer
  • php73Packages.php-parallel-lint
  • php73Packages.phpcbf
  • php73Packages.phpcs
  • php73Packages.phpstan
  • php73Packages.psalm
  • php73Packages.psysh
  • phpExtensions.xmlreader (php74Extensions.xmlreader)
  • phpPackages.box (php74Packages.box)
  • phpPackages.composer (php74Packages.composer)
  • phpPackages.composer2 (php74Packages.composer2)
  • phpPackages.php-cs-fixer (php74Packages.php-cs-fixer)
  • phpPackages.php-parallel-lint (php74Packages.php-parallel-lint)
  • phpPackages.phpcbf (php74Packages.phpcbf)
  • phpPackages.phpcs (php74Packages.phpcs)
  • phpPackages.phpmd (php74Packages.phpmd)
  • phpPackages.phpstan (php74Packages.phpstan)
  • phpPackages.psalm (php74Packages.psalm)
  • phpPackages.psysh (php74Packages.psysh)
  • php80
  • php80Extensions.xmlreader
  • php80Packages.box
  • php80Packages.composer
  • php80Packages.composer2
  • php80Packages.php-cs-fixer
  • php80Packages.php-parallel-lint
  • php80Packages.phpcbf
  • php80Packages.phpcs
  • php80Packages.phpmd
  • php80Packages.phpstan
  • php80Packages.psalm
  • php80Packages.psysh
  • pulseeffects
  • qcachegrind
  • unit
  • wp-cli
  • yle-dl

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111317 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • php80
13 packages built:
  • adminer
  • arcanist
  • drush
  • icingaweb2
  • matomo
  • matomo-beta
  • nextcloud-news-updater
  • phoronix-test-suite
  • php (php74)
  • php73
  • qcachegrind
  • wp-cli
  • yle-dl

aanderse
aanderse approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this example and php.withExtensions ({ all, enabled }: enabled ++ [ all.dom all.xmlreader ]) as the php package I was able to reproduce the error reported in #93647.

After applying this PR the error no longer exists.

@aanderse aanderse merged commit 28bbe67 into NixOS:master Feb 1, 2021
@aanderse
Copy link
Member

aanderse commented Feb 1, 2021

Thanks @talyz 🎉

@talyz talyz deleted the php-xmlreader-dom branch February 1, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP: xmlreader extension is limited due dom extension not available at build time
3 participants
@talyz @SuperSandro2000 @aanderse