Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pebble: init at 4.6.0 #111276

Merged
merged 1 commit into from Jan 30, 2021
Merged

python3Packages.pebble: init at 4.6.0 #111276

merged 1 commit into from Jan 30, 2021

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Jan 30, 2021

Motivation for this change

Needed to package cvise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

Needed to package cvise.

You can just create a single pull request with cvise and all dependencies.

dotlambda
dotlambda requested changes Jan 30, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should start with pythonPackages.pebble.

@dotlambda dotlambda changed the title python: pebble: init at 4.6.0 pythonPackages.pebble: init at 4.6.0 Jan 30, 2021
@orivej
Copy link
Contributor Author

orivej commented Jan 30, 2021 •
edited

You can just create a single pull request with cvise and all dependencies.

Yes, but cvise has another dependency that is better split (for staging) and will not reach master for a while: #111275
Splitting this dependency too reduces the amount of changes to review when cvise will be ready for PR.

The commit message should start with pythonPackages.pebble.

I though of that, but this package does not build since pebble 4.6.0 supports only python3. I'm going to change the title to python3Packages.pebble.

@orivej orivej changed the title pythonPackages.pebble: init at 4.6.0 python3Packages.pebble: init at 4.6.0 Jan 30, 2021
@dotlambda dotlambda merged commit 1d8c7f5 into NixOS:master Jan 30, 2021
@orivej orivej deleted the pebble branch January 30, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orivej @dotlambda