Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginxModules.spnego-http-auth-nginx-module: init at 16.04.2020 #111357

Merged
merged 1 commit into from Feb 8, 2021
Merged

nginxModules.spnego-http-auth-nginx-module: init at 16.04.2020 #111357

merged 1 commit into from Feb 8, 2021

Conversation

lbpdt
Copy link
Contributor

@lbpdt lbpdt commented Jan 30, 2021 •
edited

Motivation for this change

This nginx module provides Kerberos authentication and is not packaged yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lbpdt lbpdt requested a review from Izorkin January 30, 2021 22:58
@lbpdt
Copy link
Contributor Author

lbpdt commented Feb 8, 2021

Are you happy with this contribution @Izorkin ?

@Izorkin
Copy link
Contributor

Izorkin commented Feb 8, 2021

@lbpdt can you consolidate the PR into one commit? - git rebase -i HEAD~2

@lbpdt lbpdt force-pushed the feature/spnego-http-auth-nginx-module branch from 8aa323e to e7d7c51 Compare February 8, 2021 14:08
@lbpdt
Copy link
Contributor Author

lbpdt commented Feb 8, 2021

Squashed - thanks for the review!

@bhipple bhipple merged commit 5f39471 into NixOS:master Feb 8, 2021
@lbpdt lbpdt deleted the feature/spnego-http-auth-nginx-module branch February 8, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Izorkin Izorkin Izorkin approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lbpdt @Izorkin @bhipple