arm-embedded: make gcc multi-lib (arm32 + thumb) #111321
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
reviewed
Jan 30, 2021
Ericson2314
reviewed
Jan 30, 2021
cleverca22
force-pushed
the
arm-multilib
branch
from
db478ad
to
f9b2bc3
Compare
Ericson2314
reviewed
Jan 30, 2021
cleverca22
force-pushed
the
arm-multilib
branch
from
f9b2bc3
to
dee1df8
Compare
cleverca22
force-pushed
the
arm-multilib
branch
from
dee1df8
to
f053612
Compare
Ericson2314
reviewed
Feb 4, 2021
| @@ -8,7 +8,7 @@ in lib.concatLists [ | |||
| (lib.optional (p ? cpu) "--with-cpu=${p.cpu}") | |||
| (lib.optional (p ? abi) "--with-abi=${p.abi}") | |||
| (lib.optional (p ? fpu) "--with-fpu=${p.fpu}") | |||
| (lib.optional (p ? float) "--with-float=${p.float}") | |||
| (lib.optional (!targetPlatform.gcc.enableMultilib or false && (p ? float)) "--with-float=${p.float}") # --with-multilib-list conflicts with --with-float | |||
There was a problem hiding this comment.
Suggested change
| (lib.optional (!targetPlatform.gcc.enableMultilib or false && (p ? float)) "--with-float=${p.float}") # --with-multilib-list conflicts with --with-float | |
| (lib.optional (!enableMultilib && (p ? float)) "--with-float=${p.float}") # --with-multilib-list conflicts with --with-float |
I would make enableMultilib another parameter so things work even if it is overridden from the target platform
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Do you still plan to move this PR forward? In particular, did you figure out a way to set the library search path automatically instead of using environment variables to set it? This change would also be useful for |
stale
bot
removed
the
2.status: stale
|
i do want to finish this PR, but i had forgotten about it for a while |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gcc lacked a thumb version of
crtbegin.onewlib lacked a thumb version of everything
Things done
tested the resulting binaries with the expr&commands in https://gist.github.com/cleverca22/9cb66a1182fba1d660bf1b970437fb7b
confirmed that its no longer leaking arm32 opcodes into an elf binary meant for a thumb-only cpu
todo:
get the newlib multilib build properly into the linker search path, i need to manually add a
-Lflag for it currently (see the above gist)i suspect this change will also break x86 32+64bit multilib
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)