Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-cross: remove android #111255

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

release-cross: remove android #111255

wants to merge 2 commits into from

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Jan 30, 2021

AFAIK these have never succeeded, because the ndk-bundle is too large
for hydra to store. Perhaps it is best to disable this - even if we
bumped the size limit, it would take up a lot of space.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
Revert "androidenv: do not copy verbosely"
e1ee08a 
I misinterpreted the hydra error. The package is actually too large for
Hydra to store. The verbose copying is fine, and probably helpful since
the build output is otherwise very sparse.

This reverts commit b98bfb6.
@r-burns
release-cross: remove android
82a406f 
AFAIK these have never succeeded, because the ndk-bundle is too large
for hydra to store. Perhaps it is best to disable this - even if we
bumped the size limit, it would take up a lot of space.
@matthewbauer
Copy link
Member

This worked at one time because the output was small enough. I think there’s a way to reduce the size.

@r-burns r-burns marked this pull request as draft January 31, 2021 00:34
@r-burns
Copy link
Contributor Author

r-burns commented Feb 27, 2021

@matthewbauer do you know if we can we work around this by splitting up the toolchain into multiple outputs? Or does Hydra consider all outputs combined for the size limit?

@stale
Copy link

stale bot commented Aug 28, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 28, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-burns @matthewbauer @wegank