New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kreative-square-fonts: init at unstable-2021-01-29 #111238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping? |
SuperSandro2000
requested changes
Mar 22, 2021
Address comments. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Address comments. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 I've applied your suggestions as commits. Is there anything else I need to do? |
Address comments. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Thanks, I applied your suggestions again using the GitHub UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds the "Kreative Square" font, which is one of a handful of fonts in existence that have a perfect square appearance (width == height). There are actually 2 fonts. Below are their upstream descriptions:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I've built and installed this package and tested it by actually trying to use it in my Alacritty terminal, which worked.