Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kreative-square-fonts: init at unstable-2021-01-29 #111238

Merged
merged 6 commits into from Apr 1, 2021

Conversation

listx
Copy link
Member

@listx listx commented Jan 30, 2021

Motivation for this change

This adds the "Kreative Square" font, which is one of a handful of fonts in existence that have a perfect square appearance (width == height). There are actually 2 fonts. Below are their upstream descriptions:

  • Kreative Square is the main variant. Use this one if possible.
  • Kreative Square SM removes all characters not the same width as basic ASCII (combining characters, double-width characters, fixed-width spaces, etc.) for braindead programs that determine if a font is monospaced from its advance widths and not its PANOSE values (GNOME Terminal does this)."
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've built and installed this package and tested it by actually trying to use it in my Alacritty terminal, which worked.

@listx
Copy link
Member Author

listx commented Mar 19, 2021

Ping?

listx and others added 2 commits March 22, 2021 18:33
Address comments.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Address comments.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@listx
Copy link
Member Author

listx commented Mar 31, 2021

@SuperSandro2000 I've applied your suggestions as commits. Is there anything else I need to do?

Address comments.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@listx
Copy link
Member Author

listx commented Mar 31, 2021

Thanks, I applied your suggestions again using the GitHub UI.

@SuperSandro2000 SuperSandro2000 merged commit 10286fc into NixOS:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants