Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b3c5433d31dc
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 3c0ade192abd
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 30, 2021

  1. spotify: use default libgcrypt / libpng 

    Instead of overriding `libgcrypt` with the (insecure) `libgcrypt_1_5`
and `libpng` with `libpng12`, use the defaults for those two packages.

Built and checked on my NixOS desktop machine because @dotlambda said he
wouldn't check proprietary software in #111215.

`spotify` was changed to use `libgcrypt_1_5` instead of `libgcrypt` in
commit 165cb05 by @monocell in PR #8157
to address #8156, which found that:

> the current spotify client seems to depend on `libgcrypt.so.11`.
> Pretending with libgcrypt.so.20 produces an error like:
>     ... libgcrypt.so.11: version `GCRYPT_1.2' not found ...

Given that the relevant Spotify client is more than 5 years old, I don't
think we have to worry about this any more. :)

This commit helps #106203, but doesn't close it because `libgcrypt_1_5`
is still used in `staruml`.

(cherry picked from commit a61c57a)
    @9999years @erictapen
    9999years authored and erictapen committed Jan 30, 2021
    Copy the full SHA
    3c0ade1 View commit details
    Browse the repository at this point in the history