Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.dufte: 0.2.9 -> 0.2.12 #111354

Merged
merged 1 commit into from Jan 31, 2021
Merged

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jan 30, 2021

Motivation for this change

Bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -34,6 +34,10 @@ buildPythonPackage rec {
'';
checkInputs = [ pytestCheckHook ];
pythonImportsCheck = [ "dufte" ];
pytestFlagsArray = [
# we don't have the "exdown" package (yet)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to do a PR which adds exdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even so, I think this test just renders the readme and isn't useful enough to warrant the extra build-time dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already did it so whatever.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111354 run on x86_64-darwin 1

6 packages built:
  • python37Packages.dufte
  • python37Packages.perfplot
  • python38Packages.dufte
  • python38Packages.perfplot
  • python39Packages.dufte
  • python39Packages.perfplot

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111354 run on x86_64-linux 1

5 packages built:
  • python37Packages.dufte
  • python37Packages.perfplot
  • python38Packages.dufte
  • python38Packages.perfplot
  • python39Packages.dufte

@risicle risicle merged commit 97c4063 into NixOS:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants