Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perkeep: unstable-2020-03-23 -> 0.11 #111262

Merged
merged 2 commits into from Jan 31, 2021
Merged

perkeep: unstable-2020-03-23 -> 0.11 #111262

merged 2 commits into from Jan 31, 2021

Conversation

danderson
Copy link
Contributor

Signed-off-by: David Anderson dave@natulte.net

Motivation for this change

New upstream release.

Things done

Note I trimmed the produced binaries down a little, to just the client and server tools rather than also include the demo and development binaries.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danderson
perkeep: unstable-2020-03-23 -> 0.11
2fc207f 
Signed-off-by: David Anderson <dave@natulte.net>
@danderson
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 30, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 30, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested review from cstrahan and kalbasit January 30, 2021 05:27
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 111262 run on x86_64-linux 1

1 package built:
  • perkeep

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111262 run on x86_64-darwin 1

1 package built:
  • perkeep

@danderson @SuperSandro2000
Update pkgs/applications/misc/perkeep/default.nix
e445d24 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@danderson
Copy link
Contributor Author

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 31, 2021

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@danderson
Copy link
Contributor Author

My bad, I saw approval above and got trigger happy. PTAL.

@bennyandresen
Copy link
Contributor

I would prefer if the commits were squashed or the platform line received a proper commit subject. Then I would approve and set the status to needs_merger. Thanks!

@SuperSandro2000 SuperSandro2000 merged commit ab5c097 into NixOS:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@tomberek tomberek tomberek approved these changes

@bennyandresen bennyandresen Awaiting requested review from bennyandresen

@cstrahan cstrahan Awaiting requested review from cstrahan

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danderson @tomberek @SuperSandro2000 @bennyandresen